Fix AWS ECS Discovery #2706
Merged
Fix AWS ECS Discovery #2706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Aug 15, 2024
| CancellationToken token) | ||
| { | ||
| var taskArns = await ListTaskArns(ecsClient, cluster, serviceName, token); | ||
| var tasks = await DescribeTasks(ecsClient, cluster, taskArns, token); | ||
| // only return tasks with the exact same tags as the filter | ||
| var tasksWithTags = tasks.Where(task => task.Tags.IsSame(tags, TagComparer)).ToList(); | ||
| var tasksWithTags = tasks.Where(task => task.Tags.Select(t => new AwsTag(t.Key, t.Value)).Diff(tags).Count == 0).ToList(); |
There was a problem hiding this comment.
This is the actual fix, it was a porting error from Scala.
When this is ported, it is assumed that Scala list[T].diff() works by returning a distinct set of items from both the left and right list, so it is assumed that the line tags.diff(ecsTags).isEmpty literally means tags items have to match ecsTags.
Turns out list[T].diff() returns items from the left that does not have a match on the right, all it does is a linear walk on the right list and for every item in the right list removes the first matching item on the left.
So the actual correct port for the code tags.diff(ecsTags).isEmpty is actually "Is tags a subset of ecsTags"
This was referenced Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS ECS tag matching logic is wrong, it assumes that all of the tags have to match exactly
Changes
Diff()logic follows Scalalist[T].diff()behavior exactly