Update Discovery.KubernetesApi to support multi-config #2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
approved these changes
Jun 27, 2024
| @@ -14,6 +18,31 @@ internal static class ConfigExtensions | |||
| var value = config.GetString(key); | |||
| return string.IsNullOrWhiteSpace(value) || value.Equals($"<{key}>") ? null : value; | |||
| } | |||
|
|
|||
| internal static Configuration.Config MoveTo(this Configuration.Config config, string path) | |||
There was a problem hiding this comment.
Is this the same method from the Azure plugin you were working on?
| { | ||
| } | ||
|
|
||
| public KubernetesApiServiceDiscovery(ExtendedActorSystem system, Configuration.Config config) |
| @@ -35,7 +34,7 @@ public class KubernetesDiscoveryOptions: IHoconOption | |||
| public void Apply(AkkaConfigurationBuilder builder, Setup? setup = null) | |||
| { | |||
| var sb = new StringBuilder(); | |||
| sb.AppendLine($"{FullPath} {{"); | |||
| sb.AppendLine($"{KubernetesApiServiceDiscovery.FullPath(ConfigPath)} {{"); | |||
There was a problem hiding this comment.
LGTM - looks like we made the pathing more dynamic all-around here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
akka.discovery.methodvalue