Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 3.0 upgrade #3571

Closed
wants to merge 1 commit into from
Closed

Conversation

umpirsky
Copy link
Contributor

I am testing Symfony Upgrade Fixer against several Symfony projects.

Will continue pushing commits to this PR, I hope you will find them useful.

@jjanvier
Copy link
Contributor

Thanks Saša, we appreciate it very much ;)

@juliensnz
Copy link
Contributor

Wow, awesome work !

@jjanvier
Copy link
Contributor

Hello Saša @umpirsky,

Do you want to continue to work on this PR? If no, could you rebase it so that we merged it like that?
And thanks for this really cool contribution 🎉. We really appreciate 😄

@umpirsky umpirsky force-pushed the feature/symfony3-upgrade branch from d80a997 to 2869c24 Compare April 14, 2016 15:46
@umpirsky umpirsky force-pushed the feature/symfony3-upgrade branch from 2869c24 to d60fb44 Compare April 14, 2016 15:57
@umpirsky umpirsky changed the title [WIP] Symfony 3.0 upgrade Symfony 3.0 upgrade Apr 14, 2016
@umpirsky
Copy link
Contributor Author

Hi @jjanvier! :)

I just pushed an update, not much fixed now, just some form types.

Let's wait for the build. 👍

@arnolanglade
Copy link
Contributor

hi @umpirsky, can you give feedback on that PR? Can we close it ?

@umpirsky
Copy link
Contributor Author

umpirsky commented Jul 7, 2016

@Arn0d I rebased on Apr 14. As you wish, we can refix again or close, your call. ;)

@nidup nidup added the POC label Sep 21, 2016
@arnolanglade
Copy link
Contributor

@umpirsky I will close it for now. I will try Symfony-Upgrade-Fixer when we will bump Symfony to the version 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants