Update Botocore to 1.35.22#1206
Merged
jakob-keller merged 4 commits intoaio-libs:masterfrom Sep 19, 2024
Merged
Conversation
jakob-keller
approved these changes
Sep 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1206 +/- ##
==========================================
- Coverage 87.00% 86.95% -0.06%
==========================================
Files 64 64
Lines 5986 5986
==========================================
- Hits 5208 5205 -3
- Misses 778 781 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Updates Botocore higher bound to 1.35.22. This is mainly so I can pull in the boto3 updates for a project I'm working on without causing version errors with aiobotocore.
The changelog from botocore this introduces doesn't seem to introduce any changes that require corresponding updates to the aiobotocore python code:
$ git diff --name-status 1.35.16...1.35.22 botocore | grep py$ M botocore/__init__.py M botocore/configprovider.py M botocore/eventstream.py M botocore/utils.pyManually comparing the diff of those files to the classes implemented in
aiobotocore/showed no overlap.Assumptions
This is my first time working on this repo, I followed the instructions in the CONTRIBUTING doc, so I think I covered all the steps.
Checklist for All Submissions
Checklist when updating botocore and/or aiohttp versions