Skip to content

Set setuptools packages find configuration#1198

Merged
jakob-keller merged 1 commit intoaio-libs:masterfrom
jakob-keller:setuptool-no-dynamic-discovery
Sep 4, 2024
Merged

Set setuptools packages find configuration#1198
jakob-keller merged 1 commit intoaio-libs:masterfrom
jakob-keller:setuptool-no-dynamic-discovery

Conversation

@jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Sep 4, 2024

Description of Change

Set setuptools packages find configuration to avoid dynamic discovery.

Assumptions

None

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details): closes 2.14.0: create temporary directory in source tree before build trashes build #1197
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller self-assigned this Sep 4, 2024
@codecov
Copy link

codecov bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.99%. Comparing base (350c932) to head (130bd45).
Report is 25 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1198      +/-   ##
==========================================
+ Coverage   86.94%   86.99%   +0.05%     
==========================================
  Files          64       64              
  Lines        5983     5983              
==========================================
+ Hits         5202     5205       +3     
+ Misses        781      778       -3
Flag Coverage Δ
unittests 86.99% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller merged commit 53d9c09 into aio-libs:master Sep 4, 2024
@jakob-keller jakob-keller deleted the setuptool-no-dynamic-discovery branch September 4, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jakob-keller jakob-keller

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2.14.0: create temporary directory in source tree before build trashes build

1 participant

@jakob-keller