Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set timeout-minutes property for all GitHub Actions workflow jobs and check via pre-commit hook #1184

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Set timeout-minutes property for all GitHub Actions workflow jobs and check via pre-commit hook #1184

merged 2 commits into from
Aug 23, 2024

Conversation

jakob-keller
Copy link
Collaborator

Description of Change

Closes #1183

Assumptions

5 minutes is ample time for all current jobs.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller self-assigned this Aug 23, 2024
@jakob-keller jakob-keller added the github_actions Pull requests that update GitHub Actions code label Aug 23, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.99%. Comparing base (18aee5b) to head (712730e).
Report is 50 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1184   +/-   ##
=======================================
  Coverage   86.99%   86.99%           
=======================================
  Files          64       64           
  Lines        5983     5983           
=======================================
  Hits         5205     5205           
  Misses        778      778
Flag Coverage Δ
unittests 86.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@jakob-keller jakob-keller merged commit 7664723 into aio-libs:master Aug 23, 2024
10 checks passed
@jakob-keller jakob-keller deleted the github-workflow-job-timeout branch August 23, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jakob-keller jakob-keller

Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Leverage jsonschema to enforce GitHub workflow timeouts
1 participant
@jakob-keller