Skip to content

Add check-jsonschema pre-commit hook (#1172)#1180

Merged
jakob-keller merged 1 commit intoaio-libs:masterfrom
jakob-keller:check-jsonschema
Aug 23, 2024
Merged

Add check-jsonschema pre-commit hook (#1172)#1180
jakob-keller merged 1 commit intoaio-libs:masterfrom
jakob-keller:check-jsonschema

Conversation

@jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Aug 23, 2024

Description of Change

Closes #1172

Assumptions

None

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller self-assigned this Aug 23, 2024
@jakob-keller jakob-keller enabled auto-merge August 23, 2024 09:48
@codecov
Copy link

codecov bot commented Aug 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.94%. Comparing base (3e33588) to head (260b63d).
Report is 58 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1180      +/-   ##
==========================================
- Coverage   86.99%   86.94%   -0.06%     
==========================================
  Files          64       64              
  Lines        5983     5983              
==========================================
- Hits         5205     5202       -3     
- Misses        778      781       +3
Flag Coverage Δ
unittests 86.94% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@jakob-keller jakob-keller merged commit c9ec197 into aio-libs:master Aug 23, 2024
@jakob-keller jakob-keller deleted the check-jsonschema branch August 23, 2024 09:51
@webknjaz
Copy link
Member

webknjaz commented Aug 23, 2024

I also recommend using that additional schema to enforce timeouts.

@jakob-keller jakob-keller mentioned this pull request Aug 23, 2024
Closed
@jakob-keller
Copy link
Collaborator Author

jakob-keller commented Aug 23, 2024

I also recommend using that additional schema to enforce timeouts.

Opened as #1183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jakob-keller jakob-keller

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Lint JSON schema

2 participants

@jakob-keller @webknjaz