Remove setuptools dev dependency#1179
Merged
jakob-keller merged 3 commits intoaio-libs:masterfrom Aug 23, 2024
Merged
Conversation
jakob-keller
force-pushed
the
remove-setuptools-dev-dependency
branch
from
f7bc61a to
9b7cfef
Compare
13 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1179 +/- ##
==========================================
+ Coverage 86.94% 86.99% +0.05%
==========================================
Files 64 64
Lines 5983 5983
==========================================
+ Hits 5202 5205 +3
+ Misses 781 778 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
jakob-keller
force-pushed
the
remove-setuptools-dev-dependency
branch
from
9b7cfef to
0f84577
Compare
webknjaz
reviewed
Aug 23, 2024
webknjaz
approved these changes
Aug 23, 2024
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Remove all remaining occurrences of
setuptools/setup.pyin the 'development space'.Assumptions
twine check --strictin CI is adequate replacement forsetup.py checksetuptoolsis still used as build backend, as specified inpyproject.tomlChecklist for All Submissions
Checklist when updating botocore and/or aiohttp versions