Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1165 +/- ##
=======================================
Coverage 86.93% 86.93%
=======================================
Files 64 64
Lines 5978 5978
=======================================
Hits 5197 5197
Misses 781 781
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
webknjaz
reviewed
Aug 21, 2024
webknjaz
reviewed
Aug 21, 2024
jakob-keller
force-pushed
the
modernize-docs
branch
from
9a963f4 to
54bf1ec
Compare
jakob-keller
force-pushed
the
modernize-docs
branch
from
20c5558 to
e6b1a3e
Compare
webknjaz
approved these changes
Aug 21, 2024
Member
webknjaz
left a comment
webknjaz
left a comment
There was a problem hiding this comment.
I think this, is good assuming that consolidating sphinx runs would be done separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #1161
Assumptions
None
Checklist for All Submissions
Checklist when updating botocore and/or aiohttp versions