Skip to content

Fix up docs building#1155

Merged
jakob-keller merged 2 commits intoaio-libs:masterfrom
jakob-keller:docs
Aug 20, 2024
Merged

Fix up docs building#1155
jakob-keller merged 2 commits intoaio-libs:masterfrom
jakob-keller:docs

Conversation

@jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Aug 20, 2024 •
edited
Loading

Description of Change

  • Remove legacy docs/make.bat Windows batch script
  • Bump sphinx docs dependency
  • Fix deprecated intersphinx_mapping in docs/conf.py
  • Upgrade Read The Docs runners to Python 3.12

Assumptions

None

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller added the dependencies Pull requests that update a dependency file label Aug 20, 2024
@jakob-keller jakob-keller self-assigned this Aug 20, 2024
@codecov
Copy link

codecov bot commented Aug 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.98%. Comparing base (d0d71be) to head (41c3f36).
Report is 85 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1155      +/-   ##
==========================================
- Coverage   87.03%   86.98%   -0.06%     
==========================================
  Files          64       64              
  Lines        5969     5969              
==========================================
- Hits         5195     5192       -3     
- Misses        774      777       +3
Flag Coverage Δ
unittests 86.98% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller requested a review from thehesiod August 20, 2024 00:27
@thehesiod
Copy link
Collaborator

thehesiod commented Aug 20, 2024

pr machine! :)

@jakob-keller jakob-keller merged commit 1fdfd69 into aio-libs:master Aug 20, 2024
@jakob-keller jakob-keller deleted the docs branch August 20, 2024 00:39
@jakob-keller jakob-keller mentioned this pull request Aug 30, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thehesiod thehesiod thehesiod approved these changes

Assignees

@jakob-keller jakob-keller

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jakob-keller @thehesiod