Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test configuration defaults mode #1148

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Test configuration defaults mode #1148

merged 1 commit into from
Aug 18, 2024

Conversation

jakob-keller
Copy link
Collaborator

Description of Change

Test configuration defaults mode

Assumptions

None

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller self-assigned this Aug 18, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.49%. Comparing base (aab5d0e) to head (b5d667b).
Report is 106 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1148      +/-   ##
==========================================
+ Coverage   86.27%   86.49%   +0.22%     
==========================================
  Files          62       63       +1     
  Lines        5951     5962      +11     
==========================================
+ Hits         5134     5157      +23     
+ Misses        817      805      -12
Flag Coverage Δ
unittests 86.49% <100.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller merged commit 9a8e263 into aio-libs:master Aug 18, 2024
8 checks passed
@jakob-keller jakob-keller deleted the test-configuration-defaults-mode branch August 18, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jakob-keller jakob-keller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jakob-keller