Skip to content

Test error conditions of client.get_waiter()#1144

Merged
jakob-keller merged 1 commit intoaio-libs:masterfrom
jakob-keller:test-client.get_waiter
Aug 18, 2024
Merged

Test error conditions of client.get_waiter()#1144
jakob-keller merged 1 commit intoaio-libs:masterfrom
jakob-keller:test-client.get_waiter

Conversation

@jakob-keller
Copy link
Collaborator

Description of Change

Test error conditions of client.get_waiter()

Assumptions

Replace this text with any assumptions made (if any)

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller self-assigned this Aug 18, 2024
@codecov
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.24%. Comparing base (e879206) to head (2a159ad).
Report is 114 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1144      +/-   ##
==========================================
+ Coverage   86.13%   86.24%   +0.10%     
==========================================
  Files          62       63       +1     
  Lines        5944     5955      +11     
==========================================
+ Hits         5120     5136      +16     
+ Misses        824      819       -5     
Flag Coverage Δ
unittests 86.24% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller merged commit aa44442 into aio-libs:master Aug 18, 2024
@jakob-keller jakob-keller deleted the test-client.get_waiter branch August 18, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant