Skip to content

Avoid deprecated use of aiohttp in tests#1139

Merged
jakob-keller merged 1 commit intoaio-libs:masterfrom
jakob-keller:fix-ssl-in-tests
Aug 17, 2024
Merged

Avoid deprecated use of aiohttp in tests#1139
jakob-keller merged 1 commit intoaio-libs:masterfrom
jakob-keller:fix-ssl-in-tests

Conversation

@jakob-keller
Copy link
Collaborator

Description of Change

Replace deprecated aiohttp session.get() argument verify_ssl by ssl in tests. This should have been part of #1081.

Assumptions

None

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller added the bug Something isn't working label Aug 17, 2024
@jakob-keller jakob-keller self-assigned this Aug 17, 2024
@jakob-keller jakob-keller enabled auto-merge August 17, 2024 22:54
@codecov
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.16%. Comparing base (44f279e) to head (0056a7c).
Report is 123 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1139      +/-   ##
==========================================
+ Coverage   86.11%   86.16%   +0.05%     
==========================================
  Files          62       62              
  Lines        5933     5933              
==========================================
+ Hits         5109     5112       +3     
+ Misses        824      821       -3     
Flag Coverage Δ
unittests 86.16% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller merged commit 54a110b into aio-libs:master Aug 17, 2024
@jakob-keller jakob-keller deleted the fix-ssl-in-tests branch August 17, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant