Skip to content

fix moto dev dependency specification#1137

Merged
jakob-keller merged 1 commit intoaio-libs:masterfrom
jakob-keller:moto-dependency
Aug 17, 2024
Merged

fix moto dev dependency specification#1137
jakob-keller merged 1 commit intoaio-libs:masterfrom
jakob-keller:moto-dependency

Conversation

@jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Aug 17, 2024

Description of Change

From #1074: Replace invalid moto development dependency extra lambda with awslambda.

Assumptions

None

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller added the dependencies Pull requests that update a dependency file label Aug 17, 2024
@jakob-keller jakob-keller self-assigned this Aug 17, 2024
@codecov
Copy link

codecov bot commented Aug 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.11%. Comparing base (aec730a) to head (f445e2d).
Report is 127 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1137   +/-   ##
=======================================
  Coverage   86.11%   86.11%           
=======================================
  Files          62       62           
  Lines        5933     5933           
=======================================
  Hits         5109     5109           
  Misses        824      824
Flag Coverage Δ
unittests 86.11% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller marked this pull request as ready for review August 17, 2024 22:35
@jakob-keller jakob-keller merged commit c46a2bf into aio-libs:master Aug 17, 2024
@jakob-keller jakob-keller deleted the moto-dependency branch August 17, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jakob-keller jakob-keller

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jakob-keller