AG-13810 - Prevent animations on col changes when grouping is impacted #9993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewGlazier
force-pushed
the
AG-13810
branch
from
2f93156 to
aa31807
Compare
peterjrreynolds
approved these changes
Feb 28, 2025
gportela85
reviewed
Feb 28, 2025
| step: 'group', // after cols change, row grouping (the first stage) could of changed | ||
| afterColumnsChanged: true, | ||
| keepRenderedRows: true, | ||
| // we want animations if sorting or filtering could be impacted, but not if grouping has changed |
Member
There was a problem hiding this comment.
I see this comment there but there isn't a lot of detail explaining when this happens? When exactly is it important for us to animate the group step during the newColumnsLoaded.
I can see the commit that added this, but it wasn't fixing a JIRA in particular.
f5870aa
Basically, if we set animate to false here, what breaks? And if there is something that actually breaks, couldn't we pass a flag through the newColumnsLoaded event?
Member
|
Fix applied via #12605 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.