AG-13610 Improve nested object validation #9544
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliasmalik
force-pushed
the
AG-13610-validation
branch
6 times, most recently
from
39be4a2 to
55a3f0d
Compare
Stephanemw
approved these changes
Dec 16, 2024
| import { _mergeDeep } from '../../utils/object'; | ||
| import { _errMsg, toStringWithNullUndefined } from '../logging'; | ||
| import type { Deprecations, OptionsValidator, Validations } from '../validationTypes'; | ||
| import * as v from './validationSchema'; |
Member
There was a problem hiding this comment.
Can you validate that this does not break tree-shaking?
| } | ||
|
|
||
| const cellSelectionSchema = v | ||
| .object({ |
Member
There was a problem hiding this comment.
Do we have a way of keeping this in sync with the Typescript?
eliasmalik
force-pushed
the
AG-13610-validation
branch
from
1f19027 to
ab3390a
Compare
eliasmalik
force-pushed
the
AG-13610-validation
branch
from
ab3390a to
770a984
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://ag-grid.atlassian.net/browse/AG-13610