AG-14747 Remove default pinned row styles#10389
Merged
gportela85 merged 8 commits intolatestfrom May 6, 2025
Merged
Conversation
eliasmalik
force-pushed
the
AG-14747-pinned-row-style
branch
2 times, most recently
from
30e4b6d to
8507ff6
Compare
eliasmalik
force-pushed
the
AG-14747-pinned-row-style
branch
from
8507ff6 to
41939ae
Compare
BernieSumption
approved these changes
May 6, 2025
Contributor
BernieSumption
left a comment
BernieSumption
left a comment
There was a problem hiding this comment.
A query on these. font weight parameters are rare. The test we use for whether to include a parameter is that is must be at least one of:
- Used by our in-house themes
- Very commonly used by customers
- Hard to apply with CSS alone
Do any of the above apply to pinnedRowFontWeight and pinnedSourceRowFontWeight?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://ag-grid.atlassian.net/browse/AG-14747