fix: round up pixel diff calculation and usage of RAF #10095
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
PopupServiceclass in thepackages/ag-grid-community/src/widgets/popupService.tsfile. The main focus of these changes is to improve the accuracy and performance of popup positioning.Improvements to popup positioning:
initialDiffto use a rounded number for more accurate positioning.setIntervalwithrequestAnimationFramefor updating popup positions, which leverages the monitor's refresh rate for smoother animations.currentDiffto use a rounded number for consistency with theinitialDiffchange.setIntervallogic and replaced it withrequestAnimationFrameto continuously update the popup position, ensuring better performance and responsiveness.