Skip to content

Conversation

@Duskfall
Copy link

@Duskfall Duskfall commented Mar 18, 2025

This pull request includes several changes to the PopupService class in the packages/ag-grid-community/src/widgets/popupService.ts file. The main focus of these changes is to improve the accuracy and performance of popup positioning.

Improvements to popup positioning:

  • Modified the calculation of initialDiff to use a rounded number for more accurate positioning.
  • Replaced the use of setInterval with requestAnimationFrame for updating popup positions, which leverages the monitor's refresh rate for smoother animations.
  • Updated the calculation of currentDiff to use a rounded number for consistency with the initialDiff change.
  • Removed the setInterval logic and replaced it with requestAnimationFrame to continuously update the popup position, ensuring better performance and responsiveness.

@Duskfall Duskfall changed the title fix: round up pixel diff calculation and usage of raf fix: round up pixel diff calculation and usage of RAF Mar 18, 2025
@Duskfall Duskfall force-pushed the fix/popup-positioning-scrolling-raf branch from 0609833 to ca85233 Compare March 18, 2025 21:25
@Duskfall Duskfall force-pushed the fix/popup-positioning-scrolling-raf branch from ca85233 to 0b04458 Compare March 18, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant