Revert #846 / e9dfa8e #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
pkcs11
branch
from
4e8ca7d to
82a464b
Compare
Closed
Actually, I have not entirely reverted this previous patch. I have just modified the default setting: OpenSSL engines are now enabled by default, but are disabled when OPENSSL_NO_ENGINE is set. Indeed, OPENSSL_NO_ENGINE is never defined, while OPENSSL_NO_ENGINE may be defined by OpenSSL in <openssl/opensslconf.h>.
DimitriPapadopoulos
force-pushed
the
pkcs11
branch
from
82a464b to
1fe8c74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, I have not entirely reverted #846 / e9dfa8e. I have just modified the default setting: OpenSSL engines are now enabled by default, but are disabled when
OPENSSL_NO_ENGINEis set.Indeed,
OPENSSL_NO_ENGINEis never defined, whileOPENSSL_NO_ENGINEmay be defined by OpenSSL in<openssl/opensslconf.h>.Fixes #931 and #793.