parser: Handle self-closing elements and void elements #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `selfClosing` field to `nodeElement` struct to track self-closing tags - Update `match` function to accept multiple token types - Check for self-closing tags in `parseElement` and set `selfClosing` field - Return early for void elements in `parseElement` - Refactor `parseChildren` to handle both start and self-closing tags - Add `isVoidElement` function to check if a tag is a void element - Update tests to cover self-closing and void elements 🌟 These changes improve the HTML parser to properly handle self-closing elements and void elements according to the HTML spec. Fixes #126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selfClosingfield tonodeElementstruct to track self-closing tagsmatchfunction to accept multiple token typesparseElementand setselfClosingfieldparseElementparseChildrento handle both start and self-closing tagsisVoidElementfunction to check if a tag is a void element🌟 These changes improve the HTML parser to properly handle self-closing elements and void elements according to the HTML spec.
Fixes #126