Skip to content

Unifi-deploy hook updates, fixes for custom deployments #5307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Unifi-deploy hook updates, fixes for custom deployments #5307

wants to merge 5 commits into from

Conversation

3VAbdAVE
Copy link
Contributor

Fixes #3359

Moved service restart commands and system.properties to deploy variables.

Has only been tested on Unifi Dream Machine. CloudKey code has not been modified.

@3VAbdAVE 3VAbdAVE closed this Sep 27, 2024
@3VAbdAVE
Copy link
Contributor Author

Formatting fixes

@3VAbdAVE 3VAbdAVE reopened this Sep 27, 2024
@Dadeos
Copy link

Dadeos commented Sep 27, 2024

I suspect that the configuration system intends for all configuration values to be saved at the end of the script:

acme.sh/deploy/unifi.sh

Lines 268 to 273 in 2f00b9e

# Successful, so save all (non-default) config:
_savedeployconf DEPLOY_UNIFI_KEYSTORE "$DEPLOY_UNIFI_KEYSTORE"
_savedeployconf DEPLOY_UNIFI_KEYPASS "$DEPLOY_UNIFI_KEYPASS"
_savedeployconf DEPLOY_UNIFI_CLOUDKEY_CERTDIR "$DEPLOY_UNIFI_CLOUDKEY_CERTDIR"
_savedeployconf DEPLOY_UNIFI_CORE_CONFIG "$DEPLOY_UNIFI_CORE_CONFIG"
_savedeployconf DEPLOY_UNIFI_RELOAD "$DEPLOY_UNIFI_RELOAD"

(i.e. you should probably add your proposed new DEPLOY_UNIFI_OS_RELOAD and DEPLOY_UNIFI_SYSTEM_PROPERTIES configuration values in order to assist users customising them)

If I add the newly introduced DEPLOY_UNIFI_SYSTEM_PROPERTIES configuration, with an appropriate value for my deployment, then I can confirm that your proposed changes do not result in any errors being reported; if that's of any assistance.

@3VAbdAVE
Copy link
Contributor Author

Updated to save env variables.

@3VAbdAVE 3VAbdAVE closed this by deleting the head repository Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@3VAbdAVE @Dadeos