Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --no-remote-delete flag to docker entrypoint #2453

Merged
merged 4 commits into from
Jul 24, 2023
Merged

Add --no-remote-delete flag to docker entrypoint #2453

merged 4 commits into from
Jul 24, 2023

Conversation

thegoncalomartins
Copy link
Contributor

@thegoncalomartins thegoncalomartins commented Jul 20, 2023 •
edited
Loading

I think it would be a great improvement if the official base docker image for onedrive provided the possibility of having the --no-remote-delete flag.

@abraunegg
Copy link
Owner

@thegoncalomartins
Thanks for the PR - however enabling a feature - that is only meant to be active if the user enables it - by default is 100% not a good idea.

Please can you update this PR so that this is not active by default

@abraunegg abraunegg self-requested a review July 20, 2023 20:05
abraunegg
abraunegg requested changes Jul 20, 2023
View reviewed changes
Copy link
Owner

@abraunegg abraunegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not make this active by default - that is a very bad idea

@thegoncalomartins
Copy link
Contributor Author

@thegoncalomartins Thanks for the PR - however enabling a feature - that is only meant to be active if the user enables it - by default is 100% not a good idea.

Please can you update this PR so that this is not active by default

Thanks for the quick feedback.
PR Updated.

@abraunegg
Copy link
Owner

@thegoncalomartins
If you could add this to Podman.md as well from a documentation perspective that would be great

@abraunegg abraunegg merged commit 99271a4 into abraunegg:master Jul 24, 2023
@abraunegg
Copy link
Owner

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Repository owner locked and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abraunegg abraunegg Awaiting requested review from abraunegg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thegoncalomartins @abraunegg