Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert deletion of workaround for unordered SEND/RECV #32

Merged
merged 2 commits into from
Nov 27, 2020
Merged

Revert deletion of workaround for unordered SEND/RECV #32

merged 2 commits into from
Nov 27, 2020

Conversation

YusukeIwaki
Copy link
Owner

After 345a4bf, workaround logic seemed to be no longer required.
However, the unordered RECV/SEND occasionally happens...

D, [2020-11-27T18:57:37.153280 #21053] DEBUG -- : RECV << {"id"=>3, "result"=>{}, "sessionId"=>"3B6890FD90EFCE617B47AE0AA959FBF0"}
W, [2020-11-27T18:57:37.153463 #21053]  WARN -- : undefined local variable or method `id' for #<Puppeteer::CDPSession:0x00007fcc37d14a10> (NameError)
/Users/yusuke-iwaki/src/github.com/YusukeIwaki/puppeteer-ruby/lib/puppeteer/cdp_session.rb:47:in `handle_message'
/Users/yusuke-iwaki/src/github.com/YusukeIwaki/puppeteer-ruby/lib/puppeteer/connection.rb:199:in `handle_message'
/Users/yusuke-iwaki/src/github.com/YusukeIwaki/puppeteer-ruby/lib/puppeteer/define_async_method.rb:15:in `call'
/Users/yusuke-iwaki/src/github.com/YusukeIwaki/puppeteer-ruby/lib/puppeteer/define_async_method.rb:15:in `block (2 levels) in define_async_method'
/Users/yusuke-iwaki/src/github.com/YusukeIwaki/puppeteer-ruby/vendor/bundle/ruby/2.6.0/gems/concurrent-ruby-1.1.6/lib/concurrent-ruby/concurrent/promises.rb:1582:in `evaluate_to'
/Users/yusuke-iwaki/src/github.com/YusukeIwaki/puppeteer-ruby/vendor/bundle/ruby/2.6.0/gems/concurrent-ruby-1.1.6/lib/concurrent-ruby/concurrent/promises.rb:1765:in `block in on_resolvable'
/Users/yusuke-iwaki/src/github.com/YusukeIwaki/puppeteer-ruby/vendor/bundle/ruby/2.6.0/gems/concurrent-ruby-1.1.6/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:353:in `run_task'
/Users/yusuke-iwaki/src/github.com/YusukeIwaki/puppeteer-ruby/vendor/bundle/ruby/2.6.0/gems/concurrent-ruby-1.1.6/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:342:in `block (3 levels) in create_worker'
/Users/yusuke-iwaki/src/github.com/YusukeIwaki/puppeteer-ruby/vendor/bundle/ruby/2.6.0/gems/concurrent-ruby-1.1.6/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:325:in `loop'
/Users/yusuke-iwaki/src/github.com/YusukeIwaki/puppeteer-ruby/vendor/bundle/ruby/2.6.0/gems/concurrent-ruby-1.1.6/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:325:in `block (2 levels) in create_worker'
/Users/yusuke-iwaki/src/github.com/YusukeIwaki/puppeteer-ruby/vendor/bundle/ruby/2.6.0/gems/concurrent-ruby-1.1.6/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:324:in `catch'
/Users/yusuke-iwaki/src/github.com/YusukeIwaki/puppeteer-ruby/vendor/bundle/ruby/2.6.0/gems/concurrent-ruby-1.1.6/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:324:in `block in create_worker'
D, [2020-11-27T18:57:37.147072 #21053] DEBUG -- : SEND >> {"sessionId":"3B6890FD90EFCE617B47AE0AA959FBF0","method":"Target.setAutoAttach","params":{"autoAttach":true,"waitForDebuggerOnStart":false,"flatten":true},"id":3}

So revert the logic for more stability

@YusukeIwaki YusukeIwaki merged commit 397c909 into master Nov 27, 2020
@YusukeIwaki YusukeIwaki deleted the revert_workaround_for_send_recv branch November 27, 2020 11:45
@YusukeIwaki YusukeIwaki mentioned this pull request Dec 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@YusukeIwaki