Refactor event #31
Merged
Refactor event #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
lib/puppeteer/events.rb
Outdated
|
|
||
| refine Hash do | ||
| def define_const_into(target_module) | ||
| self.each do |key, value| |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
Style/RedundantSelf: Redundant self detected.
lib/puppeteer/events.rb
Outdated
| target_module.const_set(key, value) | ||
| target_module.define_singleton_method(key) { value } | ||
| end | ||
| keyset = Set.new(self.keys) |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
Style/RedundantSelf: Redundant self detected.
lib/puppeteer/events.rb
Outdated
| target_module.define_singleton_method(key) { value } | ||
| end | ||
| keyset = Set.new(self.keys) | ||
| valueset = Set.new(self.values) |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
Style/RedundantSelf: Redundant self detected.
lib/puppeteer/events.rb
Outdated
| FrameDetached: Symbol('FrameManager.FrameDetached'), | ||
| LifecycleEvent: Symbol('FrameManager.LifecycleEvent'), | ||
| FrameNavigatedWithinDocument: Symbol( | ||
| 'FrameManager.FrameNavigatedWithinDocument' |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
Style/TrailingCommaInArguments: Put a comma after the last parameter of a multiline method call.
YusukeIwaki
commented
Nov 24, 2020
lib/puppeteer/events.rb
Outdated
|
|
||
| # @see https://github.com/puppeteer/puppeteer/blob/main/src/common/Events.ts | ||
| { | ||
| Page: { |
There was a problem hiding this comment.
It seems Events.ts will be removed in future.
It would be better to define these constants in PageEmittedEvents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic of
Page#onin puppeteer-ruby was far different from original (JS) implementation.This PR introduces Events constants and makes the method similar to the original implementation.
Also, introduces XXXEmittedEvents, which is already introduces in puppeteer JS puppeteer/puppeteer#6179 or puppeteer/puppeteer#6174