Merge tag '0.31.3' into HEAD

YusukeIwaki · Mar 26, 2021 · 1883a95 · 1883a95
2 parents 4b2405f + bc9664b
commit 1883a95
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,8 +1,8 @@
-### master [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.31.2...master)]
+### master [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.31.3...master)]
 
 * xxx
 
-### 0.31.2 [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.31.1...0.31.2)]
+### 0.31.3 [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.31.1...0.31.3)]
 
 Bugfix:
 

diff --git a/docs/api_coverage.md b/docs/api_coverage.md
@@ -1,6 +1,6 @@
 # API coverages
 - Puppeteer version: v8.0.0
-- puppeteer-ruby version: 0.31.2
+- puppeteer-ruby version: 0.31.3
 
 ## Puppeteer
 

diff --git a/lib/puppeteer/version.rb b/lib/puppeteer/version.rb
@@ -1,3 +1,3 @@
 module Puppeteer
-  VERSION = '0.31.2'
+  VERSION = '0.31.3'
 end
diff --git a/lib/puppeteer/wait_task.rb b/lib/puppeteer/wait_task.rb
@@ -140,12 +140,12 @@ def rerun
           if (success) return Promise.resolve(success);
           let fulfill;
           const result = new Promise((x) => (fulfill = x));
-          const observer = new MutationObserver(() => {
+          const observer = new MutationObserver(async () => {
               if (timedOut) {
                   observer.disconnect();
                   fulfill();
               }
-              const success = predicate(...args);
+              const success = await predicate(...args);
               if (success) {
                   observer.disconnect();
                   fulfill(success);

diff --git a/spec/integration/example_spec.rb b/spec/integration/example_spec.rb
@@ -18,6 +18,11 @@
     end
   end
 
+  it {
+    page.goto('https://twitter.com/AndroidDev')
+    Timeout.timeout(10) { page.wait_for_selector('article[role="article"]') }
+  }
+
   it 'should input text and grab DOM elements' do
     skip if Puppeteer.env.ci? && !Puppeteer.env.windows?