Better browser path detection for Firefox (only for Linux)

YusukeIwaki · Nov 23, 2021 · 05b55f1 · 05b55f1
1 parent b1cad37
commit 05b55f1
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/lib/puppeteer/launcher/firefox.rb b/lib/puppeteer/launcher/firefox.rb
@@ -42,7 +42,7 @@ def launch(options = {})
         if @launch_options.channel
           executable_path_for_channel(@launch_options.channel.to_s)
         else
-          @launch_options.executable_path || executable_path_for_channel('nightly')
+          @launch_options.executable_path || fallback_executable_path
         end
       runner = Puppeteer::BrowserRunner.new(firefox_executable, firefox_arguments, temporary_user_data_dir)
       runner.start(
@@ -138,7 +138,15 @@ def executable_path(channel: nil)
       if channel
         executable_path_for_channel(channel.to_s)
       else
+        fallback_executable_path
+      end
+    end
+
+    private def fallback_executable_path
+      if Puppeteer.env.windows? || Puppeteer.env.darwin?
         executable_path_for_channel('firefox')
+      else
+        Puppeteer::ExecutablePathFinder.new('firefox').find_first
       end
     end