Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Per provider fixes. #1917

Merged
merged 3 commits into from
Nov 24, 2024
Merged

fix: Per provider fixes. #1917

merged 3 commits into from
Nov 24, 2024

Conversation

paxcut
Copy link
Contributor

@paxcut paxcut commented Sep 28, 2024

Problem description

Fixes provided for the following unreported bugs.

  • Environment variables are set to be per provider but used as if they are not. When a project is loaded all the environment variables for each provider are assigned to the first provider making it impossible to add new ones to the other providers.

  • When switching providers, the text editor selection, the text editor breakpoints, the console text, the console selection and the console cursor position of the old provider are being assigned to the new provider

Implementation description

This PR aims at fixing both errors by:

  • using variable defined to be per provider so that they affect their provider only when necessary.

  • creating new per provider variables and using them so that each provider has their own console, selections and breakpoints.

In order to support the newly added per provided features new functions were added to the text processor for selections and breakpoints. All the new per provider variables are defined and used in view pattern editor.

paxcut and others added 3 commits September 27, 2024 21:17
fix: Fix provided for the following unreported bugs.

- Environment variables are set to be per provider but used as if they are not. When a project is loaded all the environment variables for each provider are assigned to the first provider making it impossible to add new ones to the other providers.

- When switching providers, the text editor selection, the text editor breakpoints, the console text, the console selection and the console cursor position of the old provider are being assigned to the new provider

This PR aims at fixing both errors by:
- using variable defined to be per provider so that they affect their provider only when necessary.

- creating new per provider variables and using them so that each provider has their own console, selections and breakpoints.

In order to support the newly added per provided features new functions were added to the text processor for selections and breakpoints. All the new per provider variables are defined and used in view pattern editor.
@WerWolv WerWolv merged commit 1f2e453 into WerWolv:master Nov 24, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants