[Mobile] [2/n] Do not reference WalletWasabi.Daemon project directly #13900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wieslawsoltes
changed the title
wieslawsoltes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not reference WalletWasabi.Daemon project directly as its executable project and runtime identifies are not compatible with mobile androind/ios. The fix is to link only required source files and reference wasabi csproj directly,
Fix proposes here https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/5.0/referencing-executable-generates-error#recommended-action is not enough (see below error) and its still required to add mobile (android, iOS) runtime indetifiers to daemon project which isn't viable solution. Runtime indetifiers will require additional fixes in next PRs.
Requires #13899