Skip to content

Conversation

@MarnixCroes
Copy link
Collaborator

addresses #13892

these should be docs that are trivial to remove.

Other docs require more attention/review

@MarnixCroes
Copy link
Collaborator Author

I think this PR wasn't supposed to be closed, but a wrong linking?

@lontivero
Copy link
Collaborator

Sorry, yes.

@lontivero lontivero reopened this May 10, 2025
@lontivero
Copy link
Collaborator

I will review this soon.

@lontivero
Copy link
Collaborator

There are two files that makes me doubt:

Note: we don't destroy things, we just automate them. This is the same for the reproducibility issue, instead of having a document with instructions we just put those instructions in an bash script.

After automating the code coverage process we can delete this, not before. We need to wait a bit.

@lontivero lontivero merged commit 09ab2ae into WalletWasabi:master Jun 5, 2025
4 of 5 checks passed
@MarnixCroes MarnixCroes deleted the remove-old-docs branch June 10, 2025 16:09
@MarnixCroes
Copy link
Collaborator Author

There are two files that makes me doubt:

* [HardwareWalletIntegration.md](https://github.com/WalletWasabi/WalletWasabi/pull/13895/files#diff-0adf1f8975577abbf571f2d56663d9525211b6f4ab20e7ec36007b448561d12b) this instructions are okay I think.

* [WalletWasabi.Documentation/CodeCoverage.md](https://github.com/WalletWasabi/WalletWasabi/pull/13895/files#diff-d46338f8372e22ae69e12f049c241db13f35c018cd9a954c7c0995b2ccdf7f70) I think we can remove this one but only after automating the process.

Note: we don't destroy things, we just automate them. This is the same for the reproducibility issue, instead of having a document with instructions we just put those instructions in an bash script.

After automating the code coverage process we can delete this, not before. We need to wait a bit.

sorry forgot to reply here.
Yes the docs in this PR were trivial to remove, the other doc files should be updated/automated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants