Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify and validate event_level_epsilon #1097

Merged
merged 5 commits into from
Nov 29, 2023
Merged

Conversation

apasel422
Copy link
Collaborator

@apasel422 apasel422 commented Nov 7, 2023

Fixes #1095


Preview | Diff

@apasel422 apasel422 marked this pull request as ready for review November 7, 2023 16:35
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
ts/src/header-validator/validate-json.ts Outdated Show resolved Hide resolved
ts/src/header-validator/validate-json.ts Outdated Show resolved Hide resolved
@apasel422 apasel422 changed the title Specify and optionally validate event_level_epsilon Specify and validate event_level_epsilon Nov 7, 2023
@apasel422 apasel422 merged commit 722af9e into WICG:main Nov 29, 2023
3 checks passed
@apasel422 apasel422 deleted the epsilon branch November 29, 2023 18:44
aarongable pushed a commit to chromium/chromium that referenced this pull request Nov 30, 2023
WICG/attribution-reporting-api#1097

Although doing so is currently unnecessary for business logic, we
persist the value in the DB to ensure that we can retrieve it in the
future if needed. This also allows us to show it in the Attribution
Internals UI, which can aid in debugging.

We avoid a DB migration by treating absence of the corresponding proto
field as equivalent to the browser's maximum value. A DB version bump is
not needed, as prior to this change, the value was effectively a
constant used only when a source was newly stored, not after, so there
is no risk of a browser downgrade causing misinterpretation.

OBSOLETE_HISTOGRAM[Conversions.SourceRegistrationError9]=Replaced by Conversions.SourceRegistrationError10

Bug: 1500333
Change-Id: I61646ba8edf67946aa04ea7e5739a3963921c273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5010674
Reviewed-by: Nan Lin <[email protected]>
Commit-Queue: Andrew Paseltiner <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1231376}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an epsilon param to the event-level API
4 participants