-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify and validate event_level_epsilon #1097
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csharrison
requested changes
Nov 7, 2023
csharrison
approved these changes
Nov 7, 2023
apasel422
changed the title
Specify and optionally validate event_level_epsilon
Specify and validate event_level_epsilon
Nov 7, 2023
Co-authored-by: Charlie Harrison <[email protected]>
vikassahu29
approved these changes
Nov 21, 2023
akashnadan
approved these changes
Nov 29, 2023
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 30, 2023
WICG/attribution-reporting-api#1097 Although doing so is currently unnecessary for business logic, we persist the value in the DB to ensure that we can retrieve it in the future if needed. This also allows us to show it in the Attribution Internals UI, which can aid in debugging. We avoid a DB migration by treating absence of the corresponding proto field as equivalent to the browser's maximum value. A DB version bump is not needed, as prior to this change, the value was effectively a constant used only when a source was newly stored, not after, so there is no risk of a browser downgrade causing misinterpretation. OBSOLETE_HISTOGRAM[Conversions.SourceRegistrationError9]=Replaced by Conversions.SourceRegistrationError10 Bug: 1500333 Change-Id: I61646ba8edf67946aa04ea7e5739a3963921c273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5010674 Reviewed-by: Nan Lin <[email protected]> Commit-Queue: Andrew Paseltiner <[email protected]> Cr-Commit-Position: refs/heads/main@{#1231376}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1095
Preview | Diff