Skip to content

feat(Updating package): Updates lodash package to v.4.17.20 #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

simentesempre
Copy link
Contributor

@simentesempre simentesempre commented Jan 13, 2021

Updates lodash package to v.4.17.20

What:

Why:

How:

Checklist:

  • Has Breaking changes
  • Documentation
  • Tests
  • Ready to be merged
  • Added username to all-contributors list

Updates lodash package to v.4.17.20 as requested in ticket OAO-8777
https://jira.mtvi.com/browse/OAO-8777
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #465 (4d47d09) into master (44f4ca8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #465    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          139       139            
  Lines         1978      2363   +385     
  Branches       197       246    +49     
==========================================
+ Hits          1978      2363   +385     
Impacted Files Coverage Δ
packages/data-point/lib/index.js 100.00% <0.00%> (ø)
packages/data-point/lib/core/core.js 100.00% <0.00%> (ø)
packages/data-point/lib/utils/index.js 100.00% <0.00%> (ø)
packages/data-point/lib/stores/values.js 100.00% <0.00%> (ø)
packages/data-point/lib/core/transform.js 100.00% <0.00%> (ø)
packages/data-point-cache/lib/in-memory.js 100.00% <0.00%> (ø)
packages/data-point-express/lib/factory.js 100.00% <0.00%> (ø)
packages/data-point-service/lib/factory.js 100.00% <0.00%> (ø)
packages/data-point/lib/helpers/helpers.js 100.00% <0.00%> (ø)
packages/data-point/lib/stores/entities.js 100.00% <0.00%> (ø)
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ca6be1...4d47d09. Read the comment docs.

micheleriva
micheleriva previously approved these changes Jan 13, 2021
@micheleriva micheleriva added the dependencies Pull requests that update a dependency file label Jan 13, 2021
@simentesempre
Copy link
Contributor Author

Is there any other step i should take in order to get this merged?

@acatl
Copy link
Collaborator

acatl commented Jan 18, 2021 via email

… 4.17.20

Updating lodash from version 4.17.11 to version 4.17.20 in core, codemods, service and express
@micheleriva micheleriva self-requested a review March 30, 2021 12:44
@acatl acatl merged commit 3fd97b9 into ViacomInc:master Apr 20, 2021
@acatl
Copy link
Collaborator

acatl commented Apr 20, 2021

@simentesempre thanks for submitting this PR, sorry it took so long to get merged, I have upgraded the project to use Github Actions I hope this makes the Pr experience better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants