Skip to content

Upgrade javascript style and linter #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
acatl merged 2 commits into from
Sep 25, 2019
Merged

Upgrade javascript style and linter #433

acatl merged 2 commits into from
Sep 25, 2019

Conversation

@acatl
Copy link
Collaborator

@acatl acatl commented Sep 23, 2019

What:

closes #432

Checklist:

  • Has Breaking changes
  • Documentation
  • Tests
  • Ready to be merged
  • Added username to all-contributors list

@acatl acatl self-assigned this Sep 23, 2019
acatl
acatl commented Sep 23, 2019
View reviewed changes
.eslintignore
@@ -0,0 +1,2 @@
node_modules
Copy link
Collaborator Author

@acatl acatl Sep 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for whatever reason node_modules inside nested packages where getting picked up

@codecov
Copy link

codecov bot commented Sep 23, 2019 •
edited
Loading

Codecov Report

Merging #433 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #433   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         139    139           
  Lines        1982   1982           
  Branches      182    182           
=====================================
  Hits         1982   1982
Impacted Files Coverage Δ
...ucer-types/reducer-helpers/reducer-assign/index.js 100% <ø> (ø) ⬆️
...ta-point/lib/reducer-types/reducer-list/factory.js 100% <ø> (ø) ⬆️
packages/data-point/lib/reducer-types/index.js 100% <ø> (ø) ⬆️
...ucer-types/reducer-helpers/reducer-find/resolve.js 100% <ø> (ø) ⬆️
...cer-types/reducer-helpers/reducer-default/index.js 100% <ø> (ø) ⬆️
...er-types/reducer-helpers/reducer-constant/index.js 100% <ø> (ø) ⬆️
...educer-types/reducer-helpers/reducer-pick/index.js 100% <ø> (ø) ⬆️
...er-types/reducer-helpers/reducer-assign/factory.js 100% <ø> (ø) ⬆️
packages/data-point/lib/stores/entity-types.js 100% <ø> (ø) ⬆️
...-types/reducer-helpers/reducer-parallel/factory.js 100% <ø> (ø) ⬆️
... and 129 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 730a13a...918e2d7. Read the comment docs.

csarnataro
csarnataro approved these changes Sep 24, 2019
View reviewed changes
Copy link
Collaborator

@csarnataro csarnataro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this so that this PR can be merged.
To be honest I haven't checked all >300 updated files (excepting the one relevant to this PR, like .eslintrc.json and MarkDown files).
I'm just assuming that all the updates are related Airbnb migration and no new features have been added.
At least, this is what I understood from a private chat with @acatl .

@acatl acatl merged commit 6325bca into ViacomInc:master Sep 25, 2019
@acatl acatl deleted the upgrade-javascript-style-and-linter branch September 25, 2019 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csarnataro csarnataro csarnataro approved these changes

@paulmolluzzo paulmolluzzo Awaiting requested review from paulmolluzzo

@raingerber raingerber Awaiting requested review from raingerber

@abepeterkin abepeterkin Awaiting requested review from abepeterkin

Assignees

@acatl acatl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate to Airbnb Style Guide and Prettier

2 participants

@acatl @csarnataro