Catch version selector #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It needs to update the wiki page too. |
jonc125
reviewed
Sep 10, 2018
modules/LookUpCatch.cmake
Outdated
| file(MAKE_DIRECTORY "${EXTERNAL_ROOT}/include") | ||
| file(DOWNLOAD ${Catch_URL} "${Catch_FILE}") | ||
|
|
||
| file(READ "${Catch_FILE}" CATCHSTRING LIMIT 1000) |
There was a problem hiding this comment.
You should add a comment explaining what this next section is doing (checking download worked by ensuring the file is long enough).
There was a problem hiding this comment.
Yeah... that was on the original file. I imagine is checking whether the file is long enough as I suppose redirects or errors will be shorter ones.
scripts/AddCatchTest.cmake
Outdated
| find_package(Catch REQUIRED) | ||
| if(NOT Catch_FOUND AND Catch_WANTED_VERSION) | ||
| lookup_package(Catch REQUIRED ARGUMENTS VERSION ${Catch_WANTED_VERSION}) | ||
| else(NOT Catch_FOUND) |
There was a problem hiding this comment.
I think you are right... though I don't understand what the expression on else is for. Maybe just to know in which if block you are in.
|
Updated comments by @jonc125 - Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as said above. Problem was found at astro-informatics/purify#190 as in astro-informatics/purify#183 was failing after an update on Catch2.