Skip to content

Scripts/Battlegrounds: Implement Deephaul Ravine #30393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdX7 merged 15 commits into from
Feb 1, 2025
Merged

Scripts/Battlegrounds: Implement Deephaul Ravine #30393

mdX7 merged 15 commits into from
Feb 1, 2025

Conversation

@Golrag
Copy link
Contributor

@Golrag Golrag commented Oct 31, 2024 •
edited
Loading

Changes proposed:

  • Implement Deephaul Ravine
  • Make sure spawn group states are initialised before calling BattlegroundMapScript::OnInit

Issues addressed:

Closes: None

Tests performed:

  • Builds locally
  • Running around in battleground, capturing carts & crystals

Known issues and TODO list: (add/remove lines as needed)

  • Recheck with 11.0.5 on retail; see if they fixed some stuff that didnt match (texts like "the flag has been returned")
  • Check which achievement works and which not
  • [Out of Scope] When loading in the gates spawn in and you can run through them before they finish their closing animation. Update Object of every gameobject/npc is send AFTER the loading screen for some reason (in Map::Update).
  • [Out of Scope] The healing buff doesnt have a healing spell triggering. Some serverside spell stuff is going on and its not working in any bg.
  • The location where you have to drop the crystal already contains a crystal for some reason (something about npc animation?)
  • Crystal should be hidden till worldstate enables it

@Golrag Golrag force-pushed the bg_deephaul_ravine branch 2 times, most recently from 2e3bbba to 98a2b36 Compare November 1, 2024 20:17
@Golrag Golrag force-pushed the bg_deephaul_ravine branch from 268bd30 to 56d227b Compare November 17, 2024 09:23
Nyr97
Nyr97 reviewed Nov 22, 2024
View reviewed changes
src/server/scripts/Battlegrounds/DeephaulRavine/battleground_deephaul_ravine.cpp
void OnStart() override
{
BattlegroundScript::OnStart();
_scheduler.Schedule(15s, [&](TaskContext)
Copy link
Contributor

@Nyr97 Nyr97 Nov 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small improvement: do you think you can move any timer to its own enum like Timings? You can make them static constexpr std::chrono::seconds, so it's easier to maintain if anything changes rather than having magic numbs:

enum Timings { static constexpr std::chrono::seconds FlagRespawnTime = 15s; static constexpr std::chrono::seconds CartRespawnTime = 5s; }

@Golrag Golrag force-pushed the bg_deephaul_ravine branch 2 times, most recently from 994e0be to 07dc069 Compare December 21, 2024 07:53
@Golrag Golrag force-pushed the bg_deephaul_ravine branch from 16c1a17 to bf469a6 Compare December 29, 2024 10:02
@Golrag Golrag force-pushed the bg_deephaul_ravine branch from bf469a6 to 0a70e91 Compare January 19, 2025 16:06
@mdX7 mdX7 merged commit 5b83fec into TrinityCore:master Feb 1, 2025
3 of 7 checks passed
@Golrag Golrag deleted the bg_deephaul_ravine branch August 14, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdX7 mdX7 mdX7 approved these changes

+1 more reviewer

@Nyr97 Nyr97 Nyr97 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Branch-master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Golrag @mdX7 @Nyr97