Scripts/Spells: Fix Rogue Stealth with cleanup for dropped spells and… #30378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deleting related spells to move them in their own scripts
Shauren
requested changes
Nov 10, 2024
Member
There was a problem hiding this comment.
What is with this PR? I can see Master of Subtlety and Death from Above being removed from the game but Shadow Focus and Premeditation are still very much part of Subtlety talent tree.
Don't just completely remove their code without also adding their own scripts as you wrote in PR description
Contributor
Author
|
mb i had the scripts done but i forgot to push them |
Contributor
Author
|
added missing scripts |
Member
|
Conflicting files |
Contributor
Author
|
done |
Member
|
/home/runner/work/TrinityCore/TrinityCore/src/server/scripts/Spells/spell_rogue.cpp:841:2: error: expected ‘;’ after class definition |
Shauren
requested changes
Nov 16, 2024
sql/updates/world/master/2024_99_99_99_shadow_focus_and_premeditation.sql
Outdated
Show resolved
Hide resolved
sql/updates/world/master/2024_99_99_99_shadow_focus_and_premeditation.sql
Show resolved
Hide resolved
aquadeus
added a commit
to aquadeus/TrinityCore
that referenced
this pull request
Nov 29, 2024
… move some linked spells to their own separate scripts (TrinityCore#30378)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… deleting related spells to move them in their own scripts
Changes proposed:
Tests performed:
Tested in-game