Skip to content

Core/Creature: Implement aggro grace period #30362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdX7 merged 8 commits into from
Dec 29, 2024
Merged

Core/Creature: Implement aggro grace period #30362

mdX7 merged 8 commits into from
Dec 29, 2024

Conversation

@mdX7
Copy link
Member

@mdX7 mdX7 commented Oct 18, 2024 •
edited
Loading

Issues addressed:
ref #26528
supercedes #30273

Tests performed:
creatures tested: 226909, 223799
tested db spawned & temp summoned creatures

  • run into aggro range of creature after heartbeat triggered => aggro
  • kill & respawn creature while camping at respawn spot (not moving) => aggro after grace period
  • kill & respawn creature while camping at respawn spot (moving) => aggro after grace period
  • kill & respawn creature while camping at respawn spot + attacking while grace period didnt expire yet => instant aggro

@Ovahlord
Copy link
Contributor

Ovahlord commented Oct 18, 2024

aggro grace period should also get reset when engaging (Unit::AtEngage) so when a player decides to pull right away, this behavior wont remain dangling around

@Nyr97
Copy link
Contributor

Nyr97 commented Oct 19, 2024 •
edited
Loading

Does this force non-moving creatures that should be sparring with each other to aggro each other? When I was working on Silverpine, I had to force random movement from DB by 1.f for them to detect each other. Asking so that I might remove that small hackfix I had to use back 2 years ago.

@mdX7
Copy link
Member Author

mdX7 commented Oct 19, 2024

Does this force non-moving creatures that should be sparring with each other to aggro each other? When I was working on Silverpine, I had to force random movement from DB by 1.f for them to detect each other. Asking so that I might remove that small hackfix I had to use back 2 years ago.

Yes, MoveInLineOfSight triggers the aggro behavior and is manually triggered after the grace period in this pr

@mdX7 mdX7 merged commit 26d1337 into TrinityCore:master Dec 29, 2024
7 checks passed
@mdX7 mdX7 deleted the creature/aggro_grace branch December 29, 2024 08:04
Ovahlord pushed a commit that referenced this pull request Dec 29, 2024
@mdX7 @Ovahlord
Core/Creature: Implement aggro grace period (#30362)
34bd46a 
Ref: #26528 #30273 #23258
(cherry picked from commit 26d1337)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ovahlord Ovahlord Ovahlord approved these changes

Assignees

No one assigned

Labels

Branch-master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdX7 @Ovahlord @Nyr97