Scripts/Spells: Implement first aid related anti-venom item spells #30289
Conversation
|
The question now is, if we want to go with the original balance of the game or if we really want to include classic changes |
|
if it's wotlk classic it must target wotlk classic branch, oh wait :P |
|
Comments say its already nerfed in 3.1.1 (the old wotlk, not classic) and the script should be checking level of the caster of each poison aura |
|
Updated. Can quickly be tested engaging any hostile target and using .cast back 744 and .cast back 11918 or any other poison spells |
I don't think that's true though? This mentions it not working against casters of level below 60. From here
I think the source is clearly the anti-venom user, and the target is the player targetted by that anti-venom. |
|
And to me "source" is poison source - clearly wording is ambiguous (and its a user comment, not some official blz statement) |
|
Well, if the source is the poison source, the source target is still the player getting poisoned, which while not being an official statement, would line up with the guy saying it doesn't work in silithus against mobs under maxLevel. |
|
Just tested this PR, it works as intended. |
|
Conflicting files |
this is because in that place were merged the other titanium_seal_of_dalaran fix code. |
|
why does this still have wip label ? |
Changes proposed:
Makes the following first aid related items work:
Note that WotlK era introduced a hard nerf to the anti-venom items, making them take in account the target's max level instead of the poison spell level, so players couldn't abuse the items to bypass higher level poison mechanics anymore. A conversation regarding this nerf and how the items behaved on higher level targets can be seen here. This is reflected in the spell script.
While the PR targets 3.3.5, if someone seeing this takes this code to the master branch, the scriptname should also be assigned to the spell ids 172368 and 307165, from future expansions.
Issues addressed:
Closes #21518
Tests performed:
Builds & works ingame. Tested against the example in #21518 with one and multiple poison effects present.