Scripts/Elwynn Forest: Eastvale Peasant scripting #30271
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced hacky scripting for Eastvale Peasants with proper scripting. Changes proposed: Replace Hacky SAI and pathing with C++ script. This scripting operates the same as official, a repeating order of 5 paths. Tests performed: Builds. Tested in game. Closes #16608
Author
|
Working on adding StringId to 335 to rework this script. |
ghost
changed the title
ghost
changed the title
Author
|
Updated. Waiting for complaints before converting sql for master. |
added 3 commits
October 9, 2024 15:18
Some code cleanup.
Made script more robust in case of peasant death.
added 2 commits
October 9, 2024 19:21
Some magic number cleanup and reordering paths.
CraftedRO
approved these changes
Nov 16, 2024
Contributor
|
Is this good and ready to push? |
Contributor
|
@malcrom is there are reason why we are adding this with a c++ script? Couldn't this be done in DB? |
Author
SAI is painful. |
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced hacky scripting for Eastvale Peasants with proper scripting.
Changes proposed:
Replace Hacky SAI and pathing with C++ script. This scripting operates the same as official, a repeating order of 5 paths. Tests performed:
Builds. Tested in game.
Closes #16608