Skip to content

Commit

Permalink
Merge pull request #6032
Browse files Browse the repository at this point in the history
688da79 QA: add --noshutdown option to prevent stopping nodes (dexX7)
2eadeb2 QA: stop nodes after RPC tests, even with --nocleanup (dexX7)
  • Loading branch information
laanwj committed Apr 29, 2015
2 parents 23c998d + 688da79 commit e08886d
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions qa/rpc-tests/test_framework.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,10 @@ def main(self):
parser = optparse.OptionParser(usage="%prog [options]")
parser.add_option("--nocleanup", dest="nocleanup", default=False, action="store_true",
help="Leave bitcoinds and test.* datadir on exit or error")
parser.add_option("--noshutdown", dest="noshutdown", default=False, action="store_true",
help="Don't stop bitcoinds after the test execution")
parser.add_option("--srcdir", dest="srcdir", default="../../src",
help="Source directory containing bitcoind/bitcoin-cli (default: %default%)")
help="Source directory containing bitcoind/bitcoin-cli (default: %default)")
parser.add_option("--tmpdir", dest="tmpdir", default=tempfile.mkdtemp(prefix="test"),
help="Root directory for datadirs")
parser.add_option("--tracerpc", dest="trace_rpc", default=False, action="store_true",
Expand Down Expand Up @@ -128,10 +130,15 @@ def main(self):
print("Unexpected exception caught during testing: "+str(e))
traceback.print_tb(sys.exc_info()[2])

if not self.options.nocleanup:
print("Cleaning up")
if not self.options.noshutdown:
print("Stopping nodes")
stop_nodes(self.nodes)
wait_bitcoinds()
else:
print("Note: bitcoinds were not stopped and may still be running")

if not self.options.nocleanup and not self.options.noshutdown:
print("Cleaning up")
shutil.rmtree(self.options.tmpdir)

if success:
Expand Down

0 comments on commit e08886d

Please sign in to comment.