Skip to content

Commit

Permalink
use const reference as param in ConnectThroughProxy/Socks5
Browse files Browse the repository at this point in the history
- also ensure code style conformance by replacing bool static with static bool
  • Loading branch information
Philip Kaufmann committed Apr 28, 2015
1 parent 18d2832 commit d1af89e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/netbase.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ struct ProxyCredentials
};

/** Connect using SOCKS5 (as described in RFC1928) */
bool static Socks5(string strDest, int port, const ProxyCredentials *auth, SOCKET& hSocket)
static bool Socks5(const std::string& strDest, int port, const ProxyCredentials *auth, SOCKET& hSocket)
{
LogPrintf("SOCKS5 connecting %s\n", strDest);
if (strDest.size() > 255) {
Expand Down Expand Up @@ -558,7 +558,7 @@ bool IsProxy(const CNetAddr &addr) {
return false;
}

static bool ConnectThroughProxy(const proxyType &proxy, const std::string strDest, int port, SOCKET& hSocketRet, int nTimeout, bool *outProxyConnectionFailed)
static bool ConnectThroughProxy(const proxyType &proxy, const std::string& strDest, int port, SOCKET& hSocketRet, int nTimeout, bool *outProxyConnectionFailed)
{
SOCKET hSocket = INVALID_SOCKET;
// first connect to proxy server
Expand Down

0 comments on commit d1af89e

Please sign in to comment.