Skip to content

Commit

Permalink
[Wallet] comsetic non-code changes for the HD feature
Browse files Browse the repository at this point in the history
  • Loading branch information
jonasschnelli committed Jul 15, 2016
1 parent 68d7682 commit 7945088
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions qa/rpc-tests/wallet-hd.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@ def run_test (self):
self.nodes[0].generate(101)
hd_add = None
num_hd_adds = 300
for _ in range(num_hd_adds):
for i in range(num_hd_adds):
hd_add = self.nodes[1].getnewaddress()
hd_info = self.nodes[1].validateaddress(hd_add)
assert_equal(hd_info["hdkeypath"], "m/0'/0'/"+str(_+1)+"'")
assert_equal(hd_info["hdkeypath"], "m/0'/0'/"+str(i+1)+"'")
assert_equal(hd_info["hdmasterkeyid"], masterkeyid)
self.nodes[0].sendtoaddress(hd_add, 1)
self.nodes[0].generate(1)
Expand Down
4 changes: 2 additions & 2 deletions src/wallet/rpcwallet.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2269,7 +2269,7 @@ UniValue getwalletinfo(const UniValue& params, bool fHelp)
" \"keypoolsize\": xxxx, (numeric) how many new keys are pre-generated\n"
" \"unlocked_until\": ttt, (numeric) the timestamp in seconds since epoch (midnight Jan 1 1970 GMT) that the wallet is unlocked for transfers, or 0 if the wallet is locked\n"
" \"paytxfee\": x.xxxx, (numeric) the transaction fee configuration, set in " + CURRENCY_UNIT + "/kB\n"
" \"masterkeyid\": \"<hash160>\", (string) the Hash160 of the hd master pubkey\n"
" \"masterkeyid\": \"<hash160>\", (string) the Hash160 of the HD master pubkey\n"
"}\n"
"\nExamples:\n"
+ HelpExampleCli("getwalletinfo", "")
Expand All @@ -2291,7 +2291,7 @@ UniValue getwalletinfo(const UniValue& params, bool fHelp)
obj.push_back(Pair("paytxfee", ValueFromAmount(payTxFee.GetFeePerK())));
CKeyID masterKeyID = pwalletMain->GetHDChain().masterKeyID;
if (!masterKeyID.IsNull())
obj.push_back(Pair("masterkeyid",masterKeyID.GetHex()));
obj.push_back(Pair("masterkeyid", masterKeyID.GetHex()));
return obj;
}

Expand Down
6 changes: 3 additions & 3 deletions src/wallet/wallet.h
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ class CWallet : public CCryptoKeyStore, public CValidationInterface

void SyncMetaData(std::pair<TxSpends::iterator, TxSpends::iterator>);

/* the hd chain data model (external chain counters) */
/* the HD chain data model (external chain counters) */
CHDChain hdChain;

public:
Expand Down Expand Up @@ -896,10 +896,10 @@ class CWallet : public CCryptoKeyStore, public CValidationInterface

bool BackupWallet(const std::string& strDest);

/* Set the hd chain model (chain child index counters) */
/* Set the HD chain model (chain child index counters) */
bool SetHDChain(const CHDChain& chain, bool memonly);

/* Set the current hd master key (will reset the chain child index counters) */
/* Set the current HD master key (will reset the chain child index counters) */
bool SetHDMasterKey(const CKey& key);
const CHDChain& GetHDChain() { return hdChain; }
};
Expand Down
4 changes: 2 additions & 2 deletions src/wallet/walletdb.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ enum DBErrors
DB_NEED_REWRITE
};

/* simple hd chain data model */
/* simple HD chain data model */
class CHDChain
{
public:
Expand Down Expand Up @@ -79,7 +79,7 @@ class CKeyMetadata
int nVersion;
int64_t nCreateTime; // 0 means unknown
std::string hdKeypath; //optional HD/bip32 keypath
CKeyID hdMasterKeyID; //id of the hd masterkey used to derive this key
CKeyID hdMasterKeyID; //id of the HD masterkey used to derive this key

CKeyMetadata()
{
Expand Down

0 comments on commit 7945088

Please sign in to comment.