Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove obsolete an non-functional prop disableRender #838

Merged
merged 2 commits into from
Sep 23, 2024
Merged

chore: remove obsolete an non-functional prop disableRender #838

merged 2 commits into from
Sep 23, 2024

Conversation

Tinoooo
Copy link
Contributor

@Tinoooo Tinoooo commented Sep 22, 2024

No description provided.

@Tinoooo Tinoooo self-assigned this Sep 22, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 22, 2024 •
edited
Loading

✅ Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit 6f73565
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/66f0830b78ae0f00081ef51e
😎 Deploy Preview https://deploy-preview-838--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 22, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@tresjs/core@838

commit: 6f73565

@Tinoooo Tinoooo linked an issue Sep 22, 2024 that may be closed by this pull request
Component: The setting parameter disableRender of TresCanvas is ineffective when renderMode is set to always. #766
Closed
5 tasks
@Tinoooo Tinoooo mentioned this pull request Sep 22, 2024
Closed
5 tasks
@Tinoooo Tinoooo changed the title removed obsolete disableRender chore: remove obsolete prop disableRender Sep 22, 2024
@Tinoooo Tinoooo changed the title chore: remove obsolete prop disableRender chore: remove obsolete an non-functional prop disableRender Sep 22, 2024
@alvarosabu
Copy link
Member

Thanks for giving me a hand with this @Tinoooo

@alvarosabu alvarosabu merged commit 5b6488d into main Sep 23, 2024
10 of 11 checks passed
@alvarosabu alvarosabu deleted the 766-removal-of-disableRender-references branch September 23, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarosabu alvarosabu alvarosabu approved these changes

Assignees

@Tinoooo Tinoooo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component: The setting parameter disableRender of TresCanvas is ineffective when renderMode is set to always.
2 participants
@Tinoooo @alvarosabu