Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update toneMapping default to ACESFilmicToneMapping. #816

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

tommie
Copy link
Contributor

@tommie tommie commented Sep 5, 2024

Follow-up to #498.

Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit 03a4315
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/66db104b65ee63000886ba37
😎 Deploy Preview https://deploy-preview-816--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tommie
Copy link
Contributor Author

tommie commented Sep 5, 2024

I was scratching my head wondering why my white planes weren't white, and why explicitly setting NoToneMapping did something useful.

@alvarosabu
Copy link
Member

Hi @tommie sorry about the confusion caused, thanks for fixing it in the docs. 🙏🏻

@alvarosabu alvarosabu self-requested a review September 6, 2024 14:23
Copy link

pkg-pr-new bot commented Sep 6, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@tresjs/core@816

commit: 932d0ab

@alvarosabu alvarosabu merged commit bea583f into Tresjs:main Sep 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants