Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 503 conditional rendering of primitives #514

Merged
merged 10 commits into from
Feb 21, 2024
Merged

feat: 503 conditional rendering of primitives #514

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cf979fa
feat(nodeOps): switch instance logic for reactive `object` prop
alvarosabu Jan 18, 2024
5a24eea
chore: playground primitives with models
alvarosabu Jan 18, 2024
5ed02b6
chore: fix linter
alvarosabu Jan 18, 2024
8d52f32
chore: fix tests and linters, primitive object is now reactive
alvarosabu Jan 19, 2024
2df1e65
chore: refactor instance swaping logic to overwrite set and copy prop…
alvarosabu Jan 19, 2024
3490c4a
Merge branch 'v4' into feature/503-conditional-rendering-of-primitives
alvarosabu Feb 2, 2024
37ab904
chore: tests
alvarosabu Feb 2, 2024
b0ba190
chore: remove console.log
alvarosabu Feb 5, 2024
de730ef
chore: remove unused import watch
alvarosabu Feb 5, 2024
8408351
feat: add primitive conditional to patch object prop
alvarosabu Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: tests
  • Loading branch information
@alvarosabu
alvarosabu committed Feb 2, 2024
commit 37ab90419648a3685d844a2ada0643b60d17a996
42 changes: 37 additions & 5 deletions playground/src/pages/primitives.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
Group,
SphereGeometry,
} from 'three'
import { TresCanvas } from '@tresjs/core'
import { TresCanvas, useRenderLoop } from '@tresjs/core'
import { OrbitControls } from '@tresjs/cientos'
import { TresLeches, useControls } from '@tresjs/leches'
import '@tresjs/leches/styles'
Expand All @@ -29,7 +29,7 @@ const canvas = ref()
const meshRef = ref()

const { knot } = useControls({
knot: false,
knot: true,
})

const { isVisible } = useControls({
Expand Down Expand Up @@ -71,6 +71,28 @@ firstGroup.add(torusKnot)

const secondGroup = new Group()
secondGroup.add(sphere)

const primitiveRef = ref()

useRenderLoop().onLoop(() => {
if (primitiveRef.value) {
primitiveRef.value.rotation.x += 0.01
primitiveRef.value.rotation.y += 0.01
}
})

watchEffect(() => {
console.log('primitiveRef.value', primitiveRef.value)
})

const reactivePrimitiveRef = ref(new Mesh(
new TorusKnotGeometry(1, 0.5, 100, 16),
new MeshToonMaterial({
color: 'orange',
}),
))

const modelArray = ref([torus, torusKnot, sphere])
</script>

<template>
Expand All @@ -86,13 +108,23 @@ secondGroup.add(sphere)
:position="[7, 7, 7]"
/>
<OrbitControls />
<!-- <primitive
:object="reactivePrimitiveRef"
/> -->
<!-- <primitive
v-for="(model, index) of modelArray"
:key="index"
:object="model"
:position="[index * 2, index * 2, 0]"
/> -->
<primitive
v-if="isVisible"
:object="knot ? firstGroup : sphere"
ref="primitiveRef"
:object="knot ? torusKnot : torus"
/>
<Suspense>
<!-- <Suspense>
<DynamicModel />
</Suspense>
</Suspense> -->
<TresAxesHelper :args="[1]" />
<TresDirectionalLight
:position="[0, 2, 4]"
Expand Down
Loading