Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: instances re-instancing when not needed #374

Merged
merged 4 commits into from
Aug 22, 2023
Merged

fix: instances re-instancing when not needed #374

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
711dd41
fix: instances re-instancing when not needed
alvarosabu Aug 22, 2023
f0f9930
chore: remove console
alvarosabu Aug 22, 2023
e470734
chore: minor changes concerning re-instancing
Tinoooo Aug 22, 2023
9046bfb
Merge branch 'main' into bugfix/re-instances-not-working-with-dom-ele…
alvarosabu Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: remove console
  • Loading branch information
@alvarosabu
alvarosabu committed Aug 22, 2023
commit f0f9930317d9e5c62d01e6aa20a2ffcc61b82fb3
1 change: 0 additions & 1 deletion src/core/nodeOps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,6 @@ export const nodeOps: RendererOptions<TresObject, TresObject> = {
const instanceName = node.userData.tres__name || node.type

if (instanceName && prevArgs.length > 0 && !deepArrayEqual(prevArgs, args)) {
console.log('reinstancing', { instanceName, prevArgs, args })
root = Object.assign(prevNode, new catalogue.value[instanceName](...nextValue))
}
return
Expand Down
Loading