Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: group should recursive search for child elements (#728) #731

Merged
merged 6 commits into from
Jul 3, 2024
Merged

fix: group should recursive search for child elements (#728) #731

merged 6 commits into from
Jul 3, 2024

Conversation

hexianWeb
Copy link
Contributor

original func
Mesh with events cannot be collected correctly when they wrapped by TresGroup, So when collections meet Tresgroup, should recurse to the child elements.

@netlify Netlify
Copy link

netlify bot commented Jun 8, 2024 •
edited
Loading

✅ Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit 0e763d1
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/6685125b18d6e60008c92a1d
😎 Deploy Preview https://deploy-preview-731--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

garrlker
garrlker requested changes Jun 9, 2024
View reviewed changes
Copy link
Collaborator

@garrlker garrlker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! A couple suggestions and questions

src/composables/useRaycaster/index.ts Outdated Show resolved Hide resolved
@hexianWeb hexianWeb closed this Jun 10, 2024
@hexianWeb hexianWeb reopened this Jun 10, 2024
@hexianWeb hexianWeb closed this Jun 10, 2024
@hexianWeb hexianWeb reopened this Jun 10, 2024
@hexianWeb hexianWeb requested a review from garrlker June 10, 2024 03:32
@alvarosabu alvarosabu added bug Something isn't working p5-urgent-bug Fix build-breaking bugs affecting most users, should be released ASAP (priority) regression The issue only appears after a new release labels Jun 17, 2024
@hexianWeb
Copy link
Contributor Author

Merging is blocked! Is there anything I should do now?

@alvarosabu alvarosabu merged commit f09367b into Tresjs:main Jul 3, 2024
5 checks passed
@garrlker garrlker mentioned this pull request Jul 4, 2024
Closed
5 tasks
@alvarosabu alvarosabu linked an issue Jul 5, 2024 that may be closed by this pull request
Sprite - Raycast events not firing if inside group #759
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrlker garrlker garrlker approved these changes

@andretchen0 andretchen0 Awaiting requested review from andretchen0

Assignees
No one assigned
Labels
bug Something isn't working p5-urgent-bug Fix build-breaking bugs affecting most users, should be released ASAP (priority) regression The issue only appears after a new release
Projects
Team Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sprite - Raycast events not firing if inside group
4 participants
@hexianWeb @garrlker @andretchen0 @alvarosabu