Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event is not triggered in TresGroup #728

Closed
5 tasks done
hexianWeb opened this issue Jun 7, 2024 · 2 comments
Closed
5 tasks done

Event is not triggered in TresGroup #728

hexianWeb opened this issue Jun 7, 2024 · 2 comments
Assignees
@garrlker
Labels
bug Something isn't working p5-urgent-bug Fix build-breaking bugs affecting most users, should be released ASAP (priority)

Comments

@hexianWeb
Copy link
Contributor

Describe the bug

I tried writing this code into Tresjs v 4.0.2 I think this issue and issue #727 have a common cause

    <TresGroup>
      <TresMesh
        :position="[0, 0, 0]"
        @click="onClick"
        @double-click="onDoubleClick"
        @pointer-enter="onPointerEnter"
        @pointer-leave="onPointerLeave"
        @pointer-move="onPointerMove"
        @context-menu="onContextMenu"
        @pointer-missed="onPointerMissed"
      >
        <TresBoxGeometry :args="[1, 1, 1]" />
        <TresMeshToonMaterial color="#efefef" />
      </TresMesh>
    </TresGroup>

Only @pointer-missed has been triggered during this process

bandicam.2024-06-07.19-58-13-001.mp4

Reproduction

https://stackblitz.com/~/github.com/hexianWeb/starter

Steps to reproduce

switch the branch to the bug branch, or just copy this code into TheExperience.vue

    <TresGroup>
      <TresMesh
        :position="[0, 0, 0]"
        @click="onClick"
        @double-click="onDoubleClick"
        @pointer-enter="onPointerEnter"
        @pointer-leave="onPointerLeave"
        @pointer-move="onPointerMove"
        @context-menu="onContextMenu"
        @pointer-missed="onPointerMissed"
      >
        <TresBoxGeometry :args="[1, 1, 1]" />
        <TresMeshToonMaterial color="#efefef" />
      </TresMesh>
    </TresGroup>

and remove the TresGroup near camera

  <TresGroup>
    <TresPerspectiveCamera :position="[5, 5, 5]" />
  </TresGroup>

System Info

No response

Used Package Manager

pnpm

Code of Conduct
hexianWeb pushed a commit to hexianWeb/tres that referenced this issue Jun 8, 2024
fix: group should recursive search for child elements (Tresjs#728)
03099ec
@garrlker garrlker added bug Something isn't working p3-significant High-priority enhancement (priority) labels Jun 9, 2024
hexianWeb pushed a commit to hexianWeb/tres that referenced this issue Jun 10, 2024
@hexianWeb
fix: group should recursive search for child elements (Tresjs#728)
f6427ed
hexianWeb pushed a commit to hexianWeb/tres that referenced this issue Jun 10, 2024
fix: group should recursive search for child elements (Tresjs#728)
2ec25ee
@alvarosabu alvarosabu moved this to Todo in Team Board Jun 17, 2024
@alvarosabu alvarosabu added p5-urgent-bug Fix build-breaking bugs affecting most users, should be released ASAP (priority) and removed p3-significant High-priority enhancement (priority) labels Jun 17, 2024
@hexianWeb hexianWeb removed their assignment Jun 19, 2024
@hexianWeb
Copy link
Contributor Author

Sorry I removed myself from Assignees due to a mistake.

alvarosabu added a commit that referenced this issue Jul 3, 2024
@hexianWeb @alvarosabu @garrlker
fix: group should recursive search for child elements (#728) (#731)
f09367b 
* fix: group should recursive search for child elements (#728)

* fix: rename variable

---------

Co-authored-by: hexianWeb <[email protected]>
Co-authored-by: Alvaro Saburido <[email protected]>
Co-authored-by: Garrett Walker <[email protected]>
@alvarosabu alvarosabu moved this from Todo to Done in Team Board Jul 3, 2024
@garrlker
Copy link
Collaborator

This issue has been resolved

Thanks for the issue and repro @hexianWeb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garrlker garrlker

Labels
bug Something isn't working p5-urgent-bug Fix build-breaking bugs affecting most users, should be released ASAP (priority)
Projects
Team Board
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alvarosabu @garrlker @hexianWeb