Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Devtools]- Memory badge is counting the highlighter component #533

Closed
5 tasks done
alvarosabu opened this issue Feb 2, 2024 · 1 comment · Fixed by #793
Closed
5 tasks done

[Devtools]- Memory badge is counting the highlighter component #533

alvarosabu opened this issue Feb 2, 2024 · 1 comment · Fixed by #793
Labels
bug Something isn't working devtools p3-minor-bug An edge case that only affects very specific usage (priority)

Comments

@alvarosabu
Copy link
Member

Describe the bug

When selecting an object, the highlight mesh is counted on the memory consumption badge

We should filter it
https://github.com/Tresjs/tres/assets/4699008/30f52b06-5295-4a57-b05b-19ceaf11c8ac

Reproduction

Not needed

Steps to reproduce

  1. Open vue devtools
  2. Select and instance and check the badge of memory consuption

System Info

System:
    OS: macOS 14.2.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 93.17 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.14.1 - ~/.nvm/versions/node/v18.14.1/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 9.3.1 - ~/.nvm/versions/node/v18.14.1/bin/npm
  Browsers:
    Brave Browser: 120.1.61.116
    Chrome: 121.0.6167.139
    Firefox: 121.0.1
    Safari: 17.2.1
  npmPackages:
    @tresjs/cientos: ^3.7.0 => 3.7.0 
    @tresjs/core: ^3.7.0 => 3.7.0 
    @tresjs/eslint-config-vue: ^0.2.1 => 0.2.1 
    @tresjs/leches: ^0.14.0 => 0.14.0 
    @types/three: ^0.161.2 => 0.161.2 
    @vitejs/plugin-vue: ^5.0.3 => 5.0.3 
    three: ^0.161.0 => 0.161.0 
    typescript: ^5.3.3 => 5.3.3 
    vite: ^5.0.12 => 5.0.12 
    vite-plugin-glsl: ^1.2.1 => 1.2.1 
    vue: ^3.4.15 => 3.4.15 
    vue-tsc: ^1.8.27 => 1.8.27

Used Package Manager

npm

Code of Conduct
@andretchen0
Copy link
Contributor

@alvarosabu

Devtools is no longer part of the core, right? Can this be closed?

@alvarosabu alvarosabu added bug Something isn't working devtools p3-minor-bug An edge case that only affects very specific usage (priority) labels Mar 30, 2024
@alvarosabu alvarosabu moved this to In Progress in Team Board Mar 31, 2024
@alvarosabu alvarosabu moved this from In Progress to Todo in Team Board Mar 31, 2024
@alvarosabu alvarosabu removed the status in Team Board Jun 17, 2024
alvarosabu added a commit that referenced this issue Jul 26, 2024
@alvarosabu
fix: highlighted mesh counts on devtools stats #533
e0b0a3d
@alvarosabu alvarosabu mentioned this issue Jul 26, 2024
Merged
alvarosabu added a commit that referenced this issue Jul 26, 2024
@alvarosabu
fix: 792 directionallighthelpers breaks devtools (#793)
426acee 
* fix: better handling of color types for lights on devtools

* fix: highlighted mesh counts on devtools stats #533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working devtools p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
Team Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 792 directionallighthelpers breaks devtools Tresjs/tres
2 participants
@alvarosabu @andretchen0