Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raycaster: Only check for intersections when pointer moves or on click events #139

Closed
Tinoooo opened this issue Mar 3, 2023 · 0 comments · Fixed by #182
Closed

Raycaster: Only check for intersections when pointer moves or on click events #139

Tinoooo opened this issue Mar 3, 2023 · 0 comments · Fixed by #182
Assignees

Comments

@Tinoooo
Copy link
Contributor

Tinoooo commented Mar 3, 2023

Is your feature request related to a problem? Please describe.
In the current implementation, the check for intersecting objects happens on every single render cycle (see here).

Describe the solution you'd like
We could change the code in a way that the intersections are only calculated when the pointer moves or when the canvas is being clicked. Maybe there is even a possibility to only check meshes in which the respective directives (@click, ...) are used. These changes would lead to performance improvements.

Suggested solution
See above.

@Tinoooo Tinoooo self-assigned this Mar 3, 2023
@Tinoooo Tinoooo changed the title raycaster: only check for intersections when pointer moves or on click events Raycaster: Only check for intersections when pointer moves or on click events Mar 3, 2023
@alvarosabu alvarosabu added this to Tres Mar 22, 2023
@Tinoooo Tinoooo closed this as completed Mar 30, 2023
@github-project-automation github-project-automation bot moved this to Done in Tres Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant