fix: args should be empty when args was falsy (#369)

Tresjs · Aug 18, 2023 · 81b7914 · 81b7914
1 parent 453b031
commit 81b7914
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/core/nodeOps.ts b/src/core/nodeOps.ts
@@ -184,10 +184,12 @@ export const nodeOps: RendererOptions<TresObject, TresObject> = {
       let finalKey = kebabToCamel(key)
       let target = root?.[finalKey]
 
-      if (key === 'args' && !deepArrayEqual(_prevValue, nextValue)) {
+      if (key === 'args') {
         const prevNode = node as TresObject3D
+        const prevArgs = _prevValue ?? []
+        const args = nextValue ?? []
 
-        if (node.type && nextValue.length > 0) {
+        if (node.type && !deepArrayEqual(prevArgs, args)) {
           root = Object.assign(prevNode, new catalogue.value[node.type](...nextValue))
         }
         return